Attention is currently required from: Hsuan Ting Chen, Julius Werner, Yu-Ping Wu.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63115 )
Change subject: libpayload: Add commonlib/bsd/elog and its dependency
......................................................................
Patch Set 10:
(2 comments)
Patchset:
PS10:
Back to the similar implementation of PS#3, which contains
* include header in libpayload.h
* add .c to libc-srcs
unconditionally
File payloads/libpayload/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/63115/comment/0b1c7a71_eb6ec1c1
PS9, Line 51: classes-$(CONFIG_LP_ELOG) += elog
"libc" in libpayload isn't really a C library, it's a catchall bucket for all the other stuff that i […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63115
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64d0fdd2a8eff1d89a1ac451d37b61787b5564e7
Gerrit-Change-Number: 63115
Gerrit-PatchSet: 10
Gerrit-Owner: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Reviewer: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 02 Jun 2022 03:47:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen
roccochen@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment