Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33281 )
Change subject: cbfs_spi: Enable speed logging by default for BIOS_DEBUG
......................................................................
Patch Set 1:
This seems reasonable, but why is it super-useful?
I just found it very useful testing the Dual SPI patch and thought "why don't we have this on all the time?" It's probably something you want to look at at least once for every board bring-up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33281
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03c77938afe01fdcecf917e8c4c25cc29cdc764e
Gerrit-Change-Number: 33281
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:17:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment