Attention is currently required from: Kapil Porwal, Ivy Jian.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67332 )
Change subject: mb/google/rex: Add WWAN poweron sequencing
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/rex/variants/rex0/gpio.c:
https://review.coreboot.org/c/coreboot/+/67332/comment/135720ab_bb749407
PS1, Line 373: /* GPP_B17 : [] ==> EN_WWAN_PWR */
Is it possible to start doing this sequencing starting in romstage? The time delta should be minimal. Reason is if we ever need to update this after FSI, we can't change the boot block again.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67332
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6cda9348ef7f54efe5ba2358040596a1c2da1b13
Gerrit-Change-Number: 67332
Gerrit-PatchSet: 1
Gerrit-Owner: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 05 Sep 2022 15:22:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment