Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38540 )
Change subject: ec/google/chromeec: Add new wrappers for host commands ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38540/2/src/ec/google/chromeec/ec.h File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/38540/2/src/ec/google/chromeec/ec.h... PS2, Line 309: int *num_ports
Just curious: Is this input parameter strictly required? Can we return -1 on error and # of ports ot […]
That would be possible, sure. But as you mentioned, most of these functions return the error code and use "out" parameters for passing back data, so I just went with this for consistency.
https://review.coreboot.org/c/coreboot/+/38540/2/src/ec/google/chromeec/ec.h... PS2, Line 322: enum ec_pd_power_role_caps *power_role_cap, : enum ec_pd_try_power_role_caps *try_power_role_cap, : enum ec_pd_data_role_caps *data_role_cap, : enum ec_pd_port_location *port_location
Should these be put in a structure so that in the future if there are more things that need to be re […]
That's a good idea.