Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35204 )
Change subject: [TEST-ONLY] Distinguish SKU1 and 2 for eMMC and SSD respectively ......................................................................
Patch Set 3:
(5 comments)
I haven't double checked this against the schematic, but overall LGTM
https://review.coreboot.org/c/coreboot/+/35204/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/35204/3/src/mainboard/google/hatch/... PS3, Line 23: * nit: indent this
https://review.coreboot.org/c/coreboot/+/35204/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/variant.c:
https://review.coreboot.org/c/coreboot/+/35204/3/src/mainboard/google/hatch/... PS3, Line 20: void variant_devtree_update(void) Please put a newline between #includes and anything else.
https://review.coreboot.org/c/coreboot/+/35204/3/src/mainboard/google/hatch/... PS3, Line 24: Remove this empty line
https://review.coreboot.org/c/coreboot/+/35204/3/src/mainboard/google/hatch/... PS3, Line 29: Remove extra line
https://review.coreboot.org/c/coreboot/+/35204/3/src/mainboard/google/hatch/... PS3, Line 41: Remove empty line