Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38368 )
Change subject: sb/intel/i82371eb: Enable upper NVRAM bank
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38368/4/src/southbridge/intel/i8237...
File src/southbridge/intel/i82371eb/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38368/4/src/southbridge/intel/i8237...
PS4, Line 67:
The blank line came back? Judging from the other patchsets, I guess there was some git entropy?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38368
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ad127ca4394e27fc055ddf03012a195cb03bd94
Gerrit-Change-Number: 38368
Gerrit-PatchSet: 4
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 02 Feb 2020 12:13:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment