Attention is currently required from: Nico Huber, Angel Pons.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49201 )
Change subject: mb/google/parrot: Put trailing statement in the next line
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
To me, the while with in-line semicolon construct is very easy to mistake for a regular function call.
Same, it's kind of irritating.
`do; while (!exit_condition_true());`
It not only compiles, linter seems to be happy with that :) So should I change it to this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49201
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f74f25cb2e3edcdd509abd86d80098241c05741
Gerrit-Change-Number: 49201
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 08 Jan 2021 07:03:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment