Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31038 )
Change subject: src/superio: Use FixedIO
......................................................................
Patch Set 2:
FixedIO is restricted to 10-bit decode of address. So anywhere where parameter is not a literal value below 0x400 has to remain with IO(). I have doubts if it is worth changing any of these to FixedIO.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31038
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec28593b3cfd1a6061d30c4f7dec1326666b0734
Gerrit-Change-Number: 31038
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 22 Jan 2019 18:18:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment