Amol N Sukerkar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32158 )
Change subject: src/arch/x86: Enabled support for dsdt.aml ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/32158/2/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/32158/2/src/arch/x86/acpi.c@1116 PS2, Line 1116: * overriden by VBOOT mechanism.
'overriden' may be misspelled - perhaps 'overridden'?
Ack
https://review.coreboot.org/#/c/32158/2/src/arch/x86/acpi.c@1119 PS2, Line 1119: const char * name)
"foo * bar" should be "foo *bar"
Ack
https://review.coreboot.org/#/c/32158/2/src/arch/x86/acpi.c@1131 PS2, Line 1131: printk (BIOS_ERR, "ERROR: Unable to locate %s\n", prog_name(&file));
line over 80 characters
Ack
https://review.coreboot.org/#/c/32158/2/src/arch/x86/acpi.c@1131 PS2, Line 1131: printk (BIOS_ERR, "ERROR: Unable to locate %s\n", prog_name(&file));
space prohibited between function name and open parenthesis '('
Ack