build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30867 )
Change subject: mb/intel/glkrvp: Fix termination for dual voltage pins ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/#/c/30867/1/src/mainboard/intel/glkrvp/variants/... File src/mainboard/intel/glkrvp/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/30867/1/src/mainboard/intel/glkrvp/variants/... PS1, Line 73: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_46, UP_20K, DEEP, NF1, HIZCRx1, SAME), /* DSI_I2C_SDA */ line over 80 characters
https://review.coreboot.org/#/c/30867/1/src/mainboard/intel/glkrvp/variants/... PS1, Line 139: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_105, 0, DEEP, NONE, Tx0RxDCRx0, SAME),/*x4 Slot-2 Reset*/ line over 80 characters
https://review.coreboot.org/#/c/30867/1/src/mainboard/intel/glkrvp/variants/... PS1, Line 162: PAD_CFG_NF_IOSSTATE(GPIO_128, NONE, DEEP, NF1, Tx0RxDCRx0),/*PANEL0_VDDEN*/ line over 80 characters
https://review.coreboot.org/#/c/30867/1/src/mainboard/intel/glkrvp/variants/... PS1, Line 163: PAD_CFG_NF_IOSSTATE(GPIO_129, NONE, DEEP, NF1, Tx0RxDCRx0),/*PANEL0_BKLTEN*/ line over 80 characters
https://review.coreboot.org/#/c/30867/1/src/mainboard/intel/glkrvp/variants/... PS1, Line 164: PAD_CFG_NF_IOSSTATE(GPIO_130, NONE, DEEP, NF1, Tx0RxDCRx0),/*PANEL0_BKLTCTL*/ line over 80 characters
https://review.coreboot.org/#/c/30867/1/src/mainboard/intel/glkrvp/variants/... PS1, Line 170: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_136, 1, DEEP, NONE, Tx0RxDCRx0, SAME),/*DGPU Power Select*/ line over 80 characters
https://review.coreboot.org/#/c/30867/1/src/mainboard/intel/glkrvp/variants/... PS1, Line 177: PAD_CFG_GPI_APIC_IOS(GPIO_143, NONE, DEEP, LEVEL, NONE, HIZCRx1, SAME),/*DGPU Power Ok*/ line over 80 characters
https://review.coreboot.org/#/c/30867/1/src/mainboard/intel/glkrvp/variants/... PS1, Line 183: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_159, 1, DEEP, NONE, Tx0RxDCRx0, SAME),/*NFC reset*/ line over 80 characters
https://review.coreboot.org/#/c/30867/1/src/mainboard/intel/glkrvp/variants/... PS1, Line 188: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_164, 1, DEEP, NONE, Tx0RxDCRx0, SAME),/*Touch Panel Power Enable*/ line over 80 characters