Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36559 )
Change subject: lib/cbmem: Change the return type of cbmem_top to uinptr_t ......................................................................
Patch Set 8: Code-Review+1
(8 comments)
https://review.coreboot.org/c/coreboot/+/36559/8/src/northbridge/intel/gm45/... File src/northbridge/intel/gm45/northbridge.c:
https://review.coreboot.org/c/coreboot/+/36559/8/src/northbridge/intel/gm45/... PS8, Line 140: delta_cbmem = tomk - (cbmem_top() >> 10); [SPEW] this will need fixing once `sizeof(uintptr_t) != 4` happens with 64-bit support
https://review.coreboot.org/c/coreboot/+/36559/8/src/northbridge/intel/i945/... File src/northbridge/intel/i945/northbridge.c:
https://review.coreboot.org/c/coreboot/+/36559/8/src/northbridge/intel/i945/... PS8, Line 108: cbmem_topk = cbmem_top() >> 10; [SPEW] this will need fixing once `sizeof(uintptr_t) != 4` happens with 64-bit support
https://review.coreboot.org/c/coreboot/+/36559/8/src/northbridge/intel/pinev... File src/northbridge/intel/pineview/northbridge.c:
https://review.coreboot.org/c/coreboot/+/36559/8/src/northbridge/intel/pinev... PS8, Line 106: cbmem_topk = cbmem_top() >> 10; [SPEW] this will need fixing once `sizeof(uintptr_t) != 4` happens with 64-bit support
https://review.coreboot.org/c/coreboot/+/36559/8/src/northbridge/intel/x4x/n... File src/northbridge/intel/x4x/northbridge.c:
https://review.coreboot.org/c/coreboot/+/36559/8/src/northbridge/intel/x4x/n... PS8, Line 92: delta_cbmem = tomk - (cbmem_top() >> 10); [SPEW] this will need fixing once `sizeof(uintptr_t) != 4` happens with 64-bit support
https://review.coreboot.org/c/coreboot/+/36559/8/src/soc/amd/picasso/northbr... File src/soc/amd/picasso/northbridge.c:
https://review.coreboot.org/c/coreboot/+/36559/8/src/soc/amd/picasso/northbr... PS8, Line 266: uint32_t mem_useable = cbmem_top(); [SPEW] this will need fixing once `sizeof(uintptr_t) != 4` happens with 64-bit support
https://review.coreboot.org/c/coreboot/+/36559/8/src/soc/amd/stoneyridge/nor... File src/soc/amd/stoneyridge/northbridge.c:
https://review.coreboot.org/c/coreboot/+/36559/8/src/soc/amd/stoneyridge/nor... PS8, Line 418: uint32_t mem_useable = cbmem_top(); [SPEW] this will need fixing once `sizeof(uintptr_t) != 4` happens with 64-bit support
https://review.coreboot.org/c/coreboot/+/36559/8/src/soc/intel/fsp_baytrail/... File src/soc/intel/fsp_baytrail/memmap.c:
PS8: IIRC this platform no longer exists in master?
https://review.coreboot.org/c/coreboot/+/36559/8/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/memmap.c:
PS8: No longer in master