Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31822 )
Change subject: soc/intel/braswell/acpi/lpc.asl: Allocate used ROM size only ......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 2:
Patch Set 2: -Code-Review
(1 comment)
I did the +1 outside parentheses in patchset 1, but gerrit reported error. (I can't check the real error gerrit reported). For this reason I had modified it to patchset 2, but might introduce this issue.
I'll check.
Here are the example results: https://qa.coreboot.org/job/coreboot-gerrit/92939/testReport/junit/board/chr... You have to just click the Jenkins links and check the logs. If the `+1` makes mess, let's try
0xffffffff - ((CONFIG_COREBOOT_ROMSIZE_KB*1024) - 1)
It should make the trick I think.
I mean that I could not find these results of patchset 1. I'll check.