Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Set default configuration to low for gpio_178
......................................................................
Patch Set 7:
Patch Set 6:
Patch Set 6:
Hi Furquan,
I saw the CL:32255 to fix issue for ampton.
For casta, do I need to add PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */ in override table?
No, casta doesn't seem to be using GPIO_178 at all. Can you please update your commit message to remove mention of casta?
got it, thank for your explanation
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32247
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7668ff4817edfca5c6cea63db779fcea21c7af92
Gerrit-Change-Number: 32247
Gerrit-PatchSet: 7
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Apr 2019 06:04:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment