Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43865 )
Change subject: cpu/qemu-x86: Drop select SMP
......................................................................
Patch Set 3:
Isn't that needed as MAX_CPUS is one on qemu, but you can specify the core count on the command line, so you need the SMP semaphores, even when there's only one core by default?
AIUI, MAX_CPUS==1 implies that we won't start up any APs. So they'd
only be running our code if they execute the reset vector. Which they
shouldn't if Intel is emulated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43865
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c2ac221af78055879e7359bd03907f2416a9919
Gerrit-Change-Number: 43865
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 26 Sep 2020 17:49:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment