Attention is currently required from: Martin Roth, Angel Pons. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50247 )
Change subject: Documentation: Codify some guidelines for headers and chain-including ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
here is what I've tried to list: […]
I'm trying to just explain the general reasons where chain-including should be acceptable. I don't think we should try to maintain an exhaustive list somewhere, because these things change all the time (e.g. more stuff gets factored out into commonlib). The headers I'm mentioning there are just examples for the overall categories of cases (e.g. what applies to <cbfs.h> -> <commonlib/bsd/cbfs_serialized.h> also applies to <fmap.h> -> <commonlib/bsd/fmap_serialized.h>). I think the examples I mention already cover all the cases Elyes mentioned?
File Documentation/coding_style.md:
https://review.coreboot.org/c/coreboot/+/50247/comment/f99d6452_3f2bad77 PS1, Line 876: take advantage of the macro
take advantage of the `ARRAY_SIZE` macro:
I think the intention is to show what the macro does right away in this example. This is just from the original kernel coding style, I don't really want to touch it, I just wanted to update the references that obviously don't make sense for coreboot.