Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46587 )
Change subject: lenovo/g505s: proper way of IRQ table programming
......................................................................
Patch Set 2:
I'm trying to fix the IRQ routing of g505s coreboot, so that for KolibriOS it's similar to this UEFI: https://i.ibb.co/1bMSsTR/g505s-kolibrios-uefi.png
For a current coreboot master, it's 00 for all the IRQs at KolibriOS, and a coreboot log (https://pastebin.com/xfWBDQ4B) tells the errors like "Warning: Can't write PCI IRQ assignments because 'mainboard_pirq_data' structure does not exist".
For a 1st rev of change:
coreboot cbmem log - https://pastebin.com/tsMWNvRY
KolibriOS PCI - https://i.ibb.co/hmP8jxb/g505s-kolibrios-1st-rev.png - one of IRQs is not 00, which is already a good start.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46587
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32341878e31047f888502291bbdaa76dad268223
Gerrit-Change-Number: 46587
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Gergely Kiss
mail.gery@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kevin Cody
kcodyjr@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michal Zygowski
miczyg94@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 20 Oct 2020 14:25:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment