Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33616 )
Change subject: mediatek/mt8183: add a new configuration for Kodama
......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/33616/9/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/33616/9/src/mainboard/google/kukui/...
PS9, Line 51: default "Kodama" if BOARD_GOOGLE_KODAMA
oh one more thing...
can you move Kodama before Flapjack?
https://review.coreboot.org/c/coreboot/+/33616/9/src/mainboard/google/kukui/...
PS9, Line 71: KODAMA TEST
move Kodama before Flapjack
https://review.coreboot.org/c/coreboot/+/33616/9/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/33616/9/src/mainboard/google/kukui/...
PS9, Line 15: onfig BOARD_GOOGLE_KODAMA
move this before FLAPJACK
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33616
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72e80e800ba041df1dda2b0f84470d1ef58bc946
Gerrit-Change-Number: 33616
Gerrit-PatchSet: 9
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Hao He
hao.he@bitland.corp-partner.google.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Xingyu Wu
wuxy@bitland.corp-partner.google.com
Gerrit-Comment-Date: Mon, 15 Jul 2019 08:47:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment