Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39837 )
Change subject: mb/emulation/qemu-q35: Enable CHROMEOS as an option ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/39837/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39837/1//COMMIT_MSG@15 PS1, Line 15: kernel driver with drm atomic support) but it does work with virtio.
qemu has a number of different options for the -vga argument, but what is selected needs to match in […]
Ack
https://review.coreboot.org/c/coreboot/+/39837/1/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-q35/chromeos.c:
https://review.coreboot.org/c/coreboot/+/39837/1/src/mainboard/emulation/qem... PS1, Line 22: int get_write_protect_state(void)
This function is defined and used elsewhere so I can't really change it here.
Done
https://review.coreboot.org/c/coreboot/+/39837/1/src/mainboard/emulation/qem... PS1, Line 31: int get_recovery_mode_switch(void)
same as above. these functions are already defined and used by chromeos code.
Done