Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43175 )
Change subject: mb/mainboard/dedede: Update device tree for Boten
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43175/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43175/4//COMMIT_MSG@7
PS4, Line 7: mb/mainboard/dedede: Update device tree for Boten
mb/google/dedede/var/boten: Update devicetree
https://review.coreboot.org/c/coreboot/+/43175/4//COMMIT_MSG@9
PS4, Line 9: Add device tree for touchpad
It looks to me, you are adding more then just an entry for the touchpad. Please mention everything.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43175
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0c692bd7f997e9a90de646b807c6c1b37a834d2
Gerrit-Change-Number: 43175
Gerrit-PatchSet: 4
Gerrit-Owner: Yan Liu
yan.liu@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Comment-Date: Mon, 13 Jul 2020 06:51:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment