Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30831 )
Change subject: vendorcode/eltan/security/lib: Add hashing library used for measured and verified boot.
......................................................................
Patch Set 4:
Patch Set 4:
generally speaking this is generic code. Any particular reason to namespace it away into vendorcode/eltan?
This library is part of the measure_vboot_vendorcode topic.
I started with uploading a generic patch containing measured boot and verified boot. This verified boot includes checking bootblock and not using ChromeOS.
I got comment to split into parts (as I did) and also this solution should be placed into a vendor specific directory. For this reason I placed all code into vendorcode/eltan
For us it's no problem to place the code in vendorcode, but I'm not sure about the main reason for this request.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30831
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If828bde54c79e836a5b05ff0447645d7e06e819a
Gerrit-Change-Number: 30831
Gerrit-PatchSet: 4
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Feb 2019 10:33:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment