Hello build bot (Jenkins), Furquan Shaikh, Caveh Jalali, Tim Wawrzynczak, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45459
to look at the new patch set (#10).
Change subject: lib/spd: log override for spd memory part name ......................................................................
lib/spd: log override for spd memory part name
The BIOS log was looking in the spd data for the part name, but part names are stripped from generic SPDs. In those cases, devices define their DRAM part pame in the CBI and will declare the DRAM part name via overriding mainboard_get_dram_part_num().
Add a spd_set_name() call to the spd library to allow logging the memory part name in cases where the name does not exist in the actual SPD data.
BUG=b:168724473 TEST=cherry-pick change to enable this on Tiger Lake, then execute "emerge-volteer coreboot chromeos-bootimage", flash and boot volteer to kernel and verify that the BIOS log shows a part name when logging SPD information:
SPD: module part number is K4U6E3S4AA-MGCL
I also modified volteer to not override the part name and verified that this change did as expected and printed a blank string.
Change-Id: I91971e07c450492dbb0588abd1c3c692ee0d3bb0 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/include/spd_bin.h M src/lib/spd_bin.c 2 files changed, 27 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/45459/10