[coreboot-gerrit] Change in coreboot[master]: sc7180: Add SPI QUP driver

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36517 )

Change subject: sc7180: Add SPI QUP driver
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36517/5/src/mainboard/google/trogdo... 
File src/mainboard/google/trogdor/bootblock.c:

https://review.coreboot.org/c/coreboot/+/36517/5/src/mainboard/google/trogdo... 
PS5, Line 24: 	qup_spi_init(QUPV3_0_SE0, 1010 * KHz); /* H1 SPI */
...and QUPV3_1_SE0 here.

https://review.coreboot.org/c/coreboot/+/36517/5/src/mainboard/google/trogdo... 
PS5, Line 25: 	qup_spi_init(QUPV3_1_SE4, 1010 * KHz); /* EC SPI */
> According to my schematics this should be QUPV3_1_SE0.

Sorry, actually it should be QUPV3_0_SE0 here...