[coreboot-gerrit] Change in coreboot[master]: sc7280: Provide initial SoC support

[Shelley Chen (Code Review)]

Attention is currently required from: Ravi kumar, Martin Roth, Paul Menzel, Ravi Kumar Bokka, Julius Werner, mturney mturney.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45205 )

Change subject: sc7280: Provide initial SoC support
......................................................................

Patch Set 33:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/45205/comment/c5f114a2_9677118b 
PS15, Line 8:
> Ack

Hey Ravi, I don't see the commit message updated in this latest patchset.  Can you please update it as requested?

File src/soc/qualcomm/sc7280/memlayout.ld:

https://review.coreboot.org/c/coreboot/+/45205/comment/7169a932_76de0841 
PS24, Line 42: 	FMAP_CACHE(0x1485B400, 2K)
> Ack

I don't see CBFS_MCACHE in the latest patchset.

File src/soc/qualcomm/sc7280/qclib.c:

https://review.coreboot.org/c/coreboot/+/45205/comment/9f2839f5_d30b36f0 
PS6, Line 9: int qclib_soc_blob_load(void)
> Ack

Ravi, did you end up refactoring this out as Julius suggested?

File src/soc/qualcomm/sc7280/qclib.c:

https://review.coreboot.org/c/coreboot/+/45205/comment/2171ff83_2ab53733 
PS24, Line 12: 	ssize_t ssize;
> Ack

I still don't see this correction?