Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39477 )
Change subject: mb/google/dedede: Enable Intel Speed Shift Technology
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39477/6/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/waddledee/variant.c:
https://review.coreboot.org/c/coreboot/+/39477/6/src/mainboard/google/dedede...
PS6, Line 17:
Do we really required two varinat files, one under waddledee/variant.c and waddledoo/variant.c
I am not finiding any difference between these two.
Is it possible to move this variant.c file under baseboard OR am I missing here something ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39477
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id65d7981501c2f282e564bfc140f8d499d5713e8
Gerrit-Change-Number: 39477
Gerrit-PatchSet: 6
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Fri, 22 May 2020 18:14:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment