Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36777 )
Change subject: cpu/x86/lapic: Support x86_64 and clean up code
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/36777/6/src/include/cpu/x86/lapic.h
File src/include/cpu/x86/lapic.h:
https://review.coreboot.org/c/coreboot/+/36777/6/src/include/cpu/x86/lapic.h...
PS6, Line 3:
#include <stdint.h>
https://review.coreboot.org/c/coreboot/+/36777/6/src/include/cpu/x86/lapic.h...
PS6, Line 8: unsigned long
why leave this `unsigned long` here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36777
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaed1ad956d090625c7bb5cd9cf55cbae16dd82bd
Gerrit-Change-Number: 36777
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 18 Jun 2020 12:08:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment