[coreboot-gerrit] Change in coreboot[master]: cpu/x86: Put guard around align for smm_save_state_size

[Name of user not set (Code Review)]

[e-mail] has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38734 )

Change subject: cpu/x86: Put guard around align for smm_save_state_size
......................................................................

Patch Set 3:

(1 comment)

responded to query about save state size being hard coded.

https://review.coreboot.org/c/coreboot/+/38734/3/src/cpu/x86/mp_init.c 
File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/38734/3/src/cpu/x86/mp_init.c@1056 
PS3, Line 1056: 		 * value of 0x400 for this value.
> Where?

Patrick Rudolph noted in a previous comment:  "It looks like coreboot assumes 0x400 as safe value for save state. It's hard-coded everywhere in assembly."

For starters, I found this value (0x400) at the beginning of smmrelocate.S.  I will, over time, look further as the STM smm descriptor is at a defined location in the smm save state.

At the moment, the STM support code works on a Purism librem 15v4 which is a 4-core Kabylake. For other platforms and cores > 4, this is an issue that has to be worked out.