Attention is currently required from: Bao Zheng, Martin Roth, Karthik Ramasubramanian, Felix Held.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74950 )
Change subject: util/amdfwtool: Consolidate entry line regex pattern
......................................................................
Patch Set 1:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/74950/comment/b8a4a73b_0b80116c
PS1, Line 651: 3
`OPT_LEVEL` = 4 now, meaning the index has changed. Does anyone outside of this rely on these index values being stable?
https://review.coreboot.org/c/coreboot/+/74950/comment/faf109d6_42377301
PS1, Line 56: OPT_SPACE1,
This value is shifting `OPT_LEVEL` from `3` to `4`. It's also never used. Why is it needed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74950
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7289ddbbec4d5daefe64f59b687ba3a4af46d052
Gerrit-Change-Number: 74950
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 03 May 2023 19:53:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment