Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42484 )
Change subject: mb/pcengines/apu2: Update GPIO Reads & writes
......................................................................
Patch Set 2:
Patch Set 1: Code-Review+2
Patch Set 1:
I'm not even sure why there is code like this in mainboard to begin with.
It is used to turn off the LEDs in the final booting stage. Also helps indicating a normal user that the boot process is finished
The comment was really about the quality of the code, not its existence. Or that's how I interpreted it.
Expect to see a revert/rewrite of this in near future, apuX was sort of abusing the acpimmio/gpio_banks API.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42484
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied39c114bdf3637977d21f56fd7db428c52e4706
Gerrit-Change-Number: 42484
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 19 Jun 2020 10:12:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment