Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34381 )
Change subject: src/security/tpm/tss: Add support for PTT ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34381/12/src/security/tpm/tss/tcg-2... File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/34381/12/src/security/tpm/tss/tcg-2... PS12, Line 195: if (CONFIG(HAVE_INTEL_PTT)) {
It implements the CRB interface, added here https://review.coreboot. […]
That's right. The bit (according to the specs) has to be checked after the tis_open and before we are processing a command for the first time. We could also move it into tis_open, but then it would be interface specific. Maybe at some point in time, Intel decides to add another interface to their iTPM Specs and then we would need to reimplement it again for the other interface.