DAWEI CHIEN has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34545 )
Change subject: mediatek/mt8183: Init SPM driver
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34545/14/src/soc/mediatek/mt8183/sp...
File src/soc/mediatek/mt8183/spm.c:
https://review.coreboot.org/c/coreboot/+/34545/14/src/soc/mediatek/mt8183/sp...
PS14, Line 331: if CONFIG(MT8183_DRAM_EMCP)
: index = DYNA_LOAD_PCM_SUSPEND_LP4_3733;
: #else
: index = DYNA_LOAD_PCM_SUSPEND_LP4_3200;
: #endif
ok, I would update it on next version.
Hi Hung-Te,
Would you know why build fail with real code "if (CONFIG(MT8183_DRAM_EMCP))" (refer to latest patch)
Fail log as following
#!!!!! Error: Undefined Symbol 'MT8183_DRAM_EMCP' used at src/mainboard/google/kukui/Kconfig:45.
#!!!!! Error: CONFIG() used on unknown value (MT8183_DRAM_EMCP) at src/soc/mediatek/mt8183/spm.c:330.
# 2 errors
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3393a772f025b0912a5a25a63a87512454fbc86e
Gerrit-Change-Number: 34545
Gerrit-PatchSet: 15
Gerrit-Owner: DAWEI CHIEN
dawei.chien@mediatek.com
Gerrit-Reviewer: DAWEI CHIEN
dawei.chien@mediatek.com
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Tue, 20 Aug 2019 01:19:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: DAWEI CHIEN
dawei.chien@mediatek.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment