Attention is currently required from: Jamie Chen, Subrata Banik, Tim Wawrzynczak, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63675 )
Change subject: soc/intel/jasperlake: Add a workaround for cnvi
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/soc/intel/jasperlake/chip.h:
https://review.coreboot.org/c/coreboot/+/63675/comment/4ba8a26c_2a915ea9
PS1, Line 424: /*
: * This is a workaround to mitigate higher SoC power consumption in S0ix
: * when the CNVI has background activity.
: *
: * This setting can only be enabled if xtalsdqdis (Bit 22) in cppmvric1
: * register is 1.
: * 1: Enabled ; 0: Disabled
: */
: bool cnvi_s0ix_wa;
Can we also please mention
- Setting this on a system that supports S0i3 (e.g. external bypass rails) will apparently break S0ix.
- Affected Intel wireless chipsets
- Tradeoff of fewer wakes vs. higher power
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63675
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56439a406547e2ee1e47d34be14ecc9a8df04693
Gerrit-Change-Number: 63675
Gerrit-PatchSet: 1
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Jamie Chen
jamie.chen@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 18 Apr 2022 19:00:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment