Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )
Change subject: soc/mediatek: dsi: Fix EoTp flag
......................................................................
Patch Set 13:
(5 comments)
https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@9
PS11, Line 9: (
One space before "("
Done
https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@9
PS11, Line 9: Soc
SoC
Done
https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@10
PS11, Line 10: setup
set
Done
https://review.coreboot.org/c/coreboot/+/48868/11//COMMIT_MSG@14
PS11, Line 14: Boots correctly on Kukui
Something else related to b/168728787 should be tested. For example, […]
Done
https://review.coreboot.org/c/coreboot/+/48868/11/src/soc/mediatek/common/ds...
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/48868/11/src/soc/mediatek/common/ds...
PS11, Line 157: tmp_reg |= (mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) << 6;
Let's also rewrite this to […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48868
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa
Gerrit-Change-Number: 48868
Gerrit-PatchSet: 13
Gerrit-Owner: Shaoming Chen
shaoming.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Chen-Tsung Hsieh
chentsung@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-Reviewer: Nicolas Boichat
drinkcat@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-CC: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.com
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 31 Dec 2020 04:08:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment