ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38657 )
Change subject: arch/x86/include/arch: Add ROM_TASK_STATE_SEG
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38657/1/src/arch/x86/include/arch/r...
File src/arch/x86/include/arch/rom_segs.h:
https://review.coreboot.org/c/coreboot/+/38657/1/src/arch/x86/include/arch/r...
PS1, Line 20: ROM_TASK_STATE_SEG
The gdt that is referenced for the STM setup, for the SMM descriptor table, is the smm_relocate_gdt, […]
let's keep this here. And let's add a comment:
/* This define is placed here to make sure future romstage programmers know about it.
* It is used for STM setup code. */
and let's call it
#define SMM_TASK_STATE_SEG 0x20
then let's try to use it for a while until we figure out the best place.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38657
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iddb1f45444d03465a66a4ebb9fde5f206dc5b300
Gerrit-Change-Number: 38657
Gerrit-PatchSet: 2
Gerrit-Owner: cedarhouse1@comcast.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Mon, 03 Feb 2020 20:42:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: cedarhouse1@comcast.net
Gerrit-MessageType: comment