Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38734 )
Change subject: cpu/x86: Put guard around align for smm_save_state_size ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38734/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/38734/1/src/cpu/x86/mp_init.c@1056 PS1, Line 1056: if (CONFIG(STM)) this could be collapsed into the if() statement in line 1047. Also, since Patrick R. already mentioned it, maybe extend the comment to note that we have the hardcoded assumption of it being 0x400 across the tree?