Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36273 )
Change subject: lib/cbmem_top: Add a common cbmem_top implementation
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36273/1/src/include/cbmem.h
File src/include/cbmem.h:
https://review.coreboot.org/c/coreboot/+/36273/1/src/include/cbmem.h@77
PS1, Line 77: uintptr_t
Or let's just capture it in a comment somewhere so the assumptions aren't implicit. I personally think it's hard to assert that outside of qemu where RAM is consistently available vs a real implementation where we actually need different ISAs targeted across stages because one couldn't enter x86-64 mode, e.g., until ramstage.
ok.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36273
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie767542ee25483acc9a56785ce20a885e9a63098
Gerrit-Change-Number: 36273
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Fri, 25 Oct 2019 20:06:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment