EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48295 )
Change subject: mb/google/brya: Initiate peripheral buses
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48295/2/src/mainboard/google/brya/v...
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48295/2/src/mainboard/google/brya/v...
PS2, Line 33: register "PcieClkSrcUsage[3]" = "7"
Need change to 4 here.. it's a trap lol.
"PcieClkSrcUsage[4]" = "7"
"PcieClkSrcClkReq[3]" = "4"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48295
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a828bfb3ba4ee9a9b41cd4e83701672e5ef85bf
Gerrit-Change-Number: 48295
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 04 Dec 2020 08:13:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment