build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67373 )
Change subject: mb/google/dedede/variants/shotzo: Turn off LAN power in S0ix ......................................................................
Patch Set 1:
(41 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/4b58e475_955ba703 PS1, Line 8: Possible unwrapped commit description (prefer a maximum 72 chars per line)
File src/mainboard/google/dedede/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/340f4eb5_ef5448c3 PS1, Line 69: acpigen_write_if_lequal_op_int(ARG0_OP, 1); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/c76028ef_8dcb3a5d PS1, Line 69: acpigen_write_if_lequal_op_int(ARG0_OP, 1); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/8e345c95_6581462c PS1, Line 70: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/07ab26e4_697a78f9 PS1, Line 70: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/09b2a87c_0161164e PS1, Line 71: variant_generate_s0ix_hook(S0IX_ENTRY); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/f547fa7a_af3278d4 PS1, Line 71: variant_generate_s0ix_hook(S0IX_ENTRY); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/e72ca72a_683969e9 PS1, Line 72: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/06ae0766_f1104bab PS1, Line 72: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/83dd2117_66033e6c PS1, Line 73: acpigen_write_else(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/96874e00_d543546d PS1, Line 73: acpigen_write_else(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/31e23b34_7abe7332 PS1, Line 74: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/c45b08c8_36c4f435 PS1, Line 74: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/5f747677_5c5bbc32 PS1, Line 75: variant_generate_s0ix_hook(S0IX_EXIT); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/599e5ddc_61c1a270 PS1, Line 75: variant_generate_s0ix_hook(S0IX_EXIT); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/41672efe_6d2df5b0 PS1, Line 76: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/73d5d869_9f7ab5cd PS1, Line 76: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/d661854e_0eeb4ea2 PS1, Line 77: acpigen_write_if_end(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/02791937_3ee2fe0d PS1, Line 77: acpigen_write_if_end(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/35b71547_68a42b6c PS1, Line 83: acpigen_write_scope("\_SB"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/542ca2c0_57629929 PS1, Line 83: acpigen_write_scope("\_SB"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/0a56e2e9_b057280f PS1, Line 84: acpigen_write_method_serialized("MS0X", 1); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/9d88bef4_5d95ccb3 PS1, Line 84: acpigen_write_method_serialized("MS0X", 1); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/d1a7c5ac_86c94f1b PS1, Line 85: mainboard_generate_s0ix_hook(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/328c6bbf_ac3c9235 PS1, Line 85: mainboard_generate_s0ix_hook(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/cb98cf83_c1b789b7 PS1, Line 86: acpigen_write_method_end(); /* Method */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/b3bdbd47_2835d1b5 PS1, Line 86: acpigen_write_method_end(); /* Method */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/c77f0f3a_b4bb5b82 PS1, Line 87: acpigen_write_scope_end(); /* Scope */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/75983c4d_82ccceb4 PS1, Line 87: acpigen_write_scope_end(); /* Scope */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/b4817220_4412b983 PS1, Line 95: /* code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/09dd67e1_cbf2f1b5 PS1, Line 96: if (s0ix_entry == S0IX_ENTRY) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/5ce8fef3_f7f5a5b6 PS1, Line 97: implement variant operations here code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/2d73f790_27028ea3 PS1, Line 98: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/51e711d0_2faf88e5 PS1, Line 99: if (s0ix_entry == S0IX_EXIT) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/5f823168_82378b1b PS1, Line 100: implement variant operations here code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/4613c644_9dd0ecf9 PS1, Line 101: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/b25340d9_46a666e2 PS1, Line 102: */ code indent should use tabs where possible
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/ce1e7c0a_98052f67 PS1, Line 19: S0IX_EXIT, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/886fa9f8_0ae473c9 PS1, Line 19: S0IX_EXIT, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/24e877a2_afb65db5 PS1, Line 20: S0IX_ENTRY, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158125): https://review.coreboot.org/c/coreboot/+/67373/comment/8d074a27_e5e10317 PS1, Line 20: S0IX_ENTRY, please, no spaces at the start of a line