Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44939 )
Change subject: mb/google/dedede/var/drawcia: Add MIPI camera support
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44939/10/src/mainboard/google/deded...
File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44939/10/src/mainboard/google/deded...
PS10, Line 277: register "pr0" = ""\_SB.PCI0.I2C3.CAM1.PRIC""
Okay, then it sounds like at least the userspace now does the right thing and doesn't attempt to use […]
@Karthik/@Tomasz,
As per my understand, you would want to have a different or subset of power sequence for the EEPROM/NVM0, which is already possible if we set has_power_resource and define the power sequence just like the UFC,WFC and not define pr0
register "has_power_resource" = "1"
#Controls
register "clk_panel.clks[0].clknum" = "1" #IMGCLKOUT_1
register "clk_panel.clks[0].freq" = "1" #19.2 Mhz
register "gpio_panel.gpio[0].gpio_num" = "GPP_D13" #power_enable_2p8
register "gpio_panel.gpio[1].gpio_num" = "GPP_D14" #power_enable_1p2
#_ON
register "on_seq.ops_cnt" = "5"
register "on_seq.ops[0]" = "SEQ_OPS_CLK_ENABLE(0, 0)"
register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(0, 5)"
register "on_seq.ops[2]" = "SEQ_OPS_GPIO_ENABLE(1, 5)"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96f2ef682dff851d7788c2b612765a92228ddf75
Gerrit-Change-Number: 44939
Gerrit-PatchSet: 13
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Andy Yeh
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tian Shu Qiu
tian.shu.qiu@intel.com
Gerrit-Reviewer: Tomasz Figa
tfiga@google.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Yeh
andy.yeh@intel.com
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-CC: Matt Delco
delco@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sugnan Prabhu S
sugnan.prabhu.s@intel.corp-partner.google.com
Gerrit-Comment-Date: Thu, 22 Oct 2020 07:39:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andy Yeh
andy.yeh@intel.com
Comment-In-Reply-To: Tomasz Figa
tfiga@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: ShawnX Tu
shawnx.tu@intel.com
Gerrit-MessageType: comment