Attention is currently required from: Hung-Te Lin, Paul Menzel, Runyang Chen, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84896?usp=email )
Change subject: soc/mediatek/mt8196: Disable irq2axi feature ......................................................................
Patch Set 5:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84896/comment/1e138daa_01765b5d?usp... : PS1, Line 13: TEST=Build pass and the interrupt can be correctly handled.
Please mention the problems/symptoms in the commit message. […]
Done
File src/soc/mediatek/mt8196/include/soc/irq2axi.h:
https://review.coreboot.org/c/coreboot/+/84896/comment/47e1183f_db0907cc?usp... : PS3, Line 6: #include <device/mmio.h>
move to c file
Done
https://review.coreboot.org/c/coreboot/+/84896/comment/64b12129_a5c6c545?usp... : PS3, Line 8:
use tab for indent
Done
https://review.coreboot.org/c/coreboot/+/84896/comment/25d5c5bc_9549b31b?usp... : PS3, Line 13: (
remove parentheses
Done
https://review.coreboot.org/c/coreboot/+/84896/comment/40d89026_595554f1?usp... : PS3, Line 16: )
ditto
Done
File src/soc/mediatek/mt8196/irq2axi.c:
https://review.coreboot.org/c/coreboot/+/84896/comment/53c0bc8b_dc2a27be?usp... : PS3, Line 8: printk(BIOS_INFO, "%s\n", __func__);
Please make it debug level or reword it. […]
Done