[coreboot-gerrit] Change in coreboot[master]: mb/kontron/986lcd-m: Use `winbond_enable_serial()`

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39125 )

Change subject: mb/kontron/986lcd-m: Use `winbond_enable_serial()`
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39125/1/src/mainboard/kontron/986lc... 
File src/mainboard/kontron/986lcd-m/early_init.c:

https://review.coreboot.org/c/coreboot/+/39125/1/src/mainboard/kontron/986lc... 
PS1, Line 60: dev = PNP_DEV(0x2e, W83627THG_SP2);
            : 	winbond_enable_serial(dev, 0x2f8);
            : 
            : 	pnp_enter_conf_state(dev);
            : 
            : 	dev = PNP_DEV(0x2e, W83627THG_KBC);
            : 	pnp_set_logical_device(dev);
            : 	pnp_set_enable(dev, 0);
            : 	pnp_set_iobase(dev, PNP_IDX_IO0, 0x60);
            : 	pnp_set_iobase(dev, PNP_IDX_IO1, 0x64);
            : 	pnp_set_enable(dev, 1);
            : 
            : 	dev = PNP_DEV(0x2e, W83627THG_GAME_MIDI_GPIO1);
            : 	pnp_set_logical_device(dev);
            : 	pnp_set_enable(dev, 0);
            : 	pnp_write_config(dev, 0xf5, 0xff); /* invert all GPIOs */
            : 	pnp_set_enable(dev, 1);
            : 
            : 	dev = PNP_DEV(0x2e, W83627THG_GPIO2);
            : 	pnp_set_logical_device(dev);
            : 	pnp_set_enable(dev, 1); /* Just enable it */
            : 
            : 	dev = PNP_DEV(0x2e, W83627THG_GPIO3);
            : 	pnp_set_logical_device(dev);
            : 	pnp_set_enable(dev, 0);
            : 	pnp_write_config(dev, 0xf0, 0xfb); /* GPIO bit 2 is output */
            : 	pnp_write_config(dev, 0xf1, 0x00); /* GPIO bit 2 is 0 */
            : 	pnp_write_config(dev, 0x30, 0x03); /* Enable GPIO3+4. pnp_set_enable is not sufficient */
            : 
            : 	dev = PNP_DEV(0x2e, W83627THG_FDC);
            : 	pnp_set_logical_device(dev);
            : 	pnp_set_enable(dev, 0);
            : 
            : 	dev = PNP_DEV(0x2e, W83627THG_PP);
            : 	pnp_set_logical_device(dev);
            : 	pnp_set_enable(dev, 0);
            : 
            : 	/* Enable HWM */
            : 	dev = PNP_DEV(0x2e, W83627THG_HWM);
            : 	pnp_set_logical_device(dev);
            : 	pnp_set_enable(dev, 0);
            : 	pnp_set_iobase(dev, PNP_IDX_IO0, 0xa00);
            : 	pnp_set_enable(dev, 1);
            : 
            : 	pnp_exit_conf_state(dev);
            : 
            : 	dev = PNP_DEV(0x4e, W83627THG_SP1);
            : 	pnp_enter_conf_state(dev);
            : 
            : 	pnp_set_logical_device(dev); /* Set COM3 to sane non-conflicting values */
            : 	pnp_set_enable(dev, 0);
            : 	pnp_set_iobase(dev, PNP_IDX_IO0, 0x3e8);
            : 	pnp_set_irq(dev, PNP_IDX_IRQ0, 11);
            : 	pnp_set_enable(dev, 1);
            : 
            : 	dev = PNP_DEV(0x4e, W83627THG_SP2);
            : 	pnp_set_logical_device(dev); /* Set COM4 to sane non-conflicting values */
            : 	pnp_set_enable(dev, 0);
            : 	pnp_set_iobase(dev, PNP_IDX_IO0, 0x2e8);
            : 	pnp_set_irq(dev, PNP_IDX_IRQ0, 10);
            : 	pnp_set_enable(dev, 1);
            : 
            : 	dev = PNP_DEV(0x4e, W83627THG_FDC);
            : 	pnp_set_logical_device(dev);
            : 	pnp_set_enable(dev, 0);
            : 
            : 	dev = PNP_DEV(0x4e, W83627THG_PP);
            : 	pnp_set_logical_device(dev);
            : 	pnp_set_enable(dev, 0);
            : 
            : 	dev = PNP_DEV(0x4e, W83627THG_KBC);
            : 	pnp_set_logical_device(dev);
            : 	pnp_set_enable(dev, 0);
            : 	pnp_set_iobase(dev, PNP_IDX_IO0, 0x00);
            : 	pnp_set_iobase(dev, PNP_IDX_IO1, 0x00);
            : 
            : 	pnp_exit_conf_state(dev);
> I think you can remove all of this ...

Please elaborate? Because it’s done somewhere else, and not needed in bootblock?