Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33737 )
Change subject: device/oprom/realmode: Add vbe return status support as per VBE spec 3.0 ......................................................................
Patch Set 13:
(6 comments)
https://review.coreboot.org/c/coreboot/+/33737/5/src/device/oprom/realmode/x... File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/33737/5/src/device/oprom/realmode/x... PS5, Line 315: die("\nError: In %s function\n", __func__);
if we don't die here, it will eventually hang during depthcharge while displaying bmpblk as mentione […]
Done
https://review.coreboot.org/c/coreboot/+/33737/5/src/device/oprom/realmode/x... PS5, Line 326: /* request clearing of framebuffer */
okay i will push one
Done
https://review.coreboot.org/c/coreboot/+/33737/8/src/device/oprom/realmode/x... File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/33737/8/src/device/oprom/realmode/x... PS8, Line 246: mode = *video_mode_ptr++;
i have enable depthcharge console and dump 0xc0258 when i create 20 bit address as below. […]
The follow up commit properly handles segment and offset now (plus, it's in the follow up, with no bearing on this commit anymore)
https://review.coreboot.org/c/coreboot/+/33737/9/src/include/vbe.h File src/include/vbe.h:
https://review.coreboot.org/c/coreboot/+/33737/9/src/include/vbe.h@47 PS9, Line 47: } __packed vbe_info_t;
thanks.
Done
https://review.coreboot.org/c/coreboot/+/33737/9/src/include/vbe.h@59 PS9, Line 59: } vbe_info_t;
thanks
Done
https://review.coreboot.org/c/coreboot/+/33737/5/src/include/vbe.h File src/include/vbe.h:
PS5:
i will submit another CL
Done