Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31108 )
Change subject: sb/intel/common/firmware: Don't call GbE binary `firmware` ......................................................................
Patch Set 1:
(1 comment)
As per Intel document this region holds "Lan FW + MAC address".
do you think " Don't call GbE binary `firmware`" is justified here ?
Yes, pretty much justified.
As per Intel document, this region is described as follows:
The NVM image contains both static and dynamic data. The static data is the basic platform configuration, and includes OEM specific configuration bits as well as the unique Printed Circuit Board Assembly (PBA). The dynamic data holds the product’s Ethernet Individual Address (IA) and Checksum. This file can be created using a text editor.
Doesn't sound anything like firmware to me. That's from "Intel ® 82579 Gigabit Ethernet PHY Datasheet v2.1" btw.
https://review.coreboot.org/#/c/31108/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31108/1//COMMIT_MSG@8 PS1, Line 8:
can you please point me to the document where you get those details about referring as Gbe "configur […]
Well, quoting undisclosed documentation isn't helpful. Also, I don't care what a random document calls it. I'm sure even for Intel insiders the binary situation can be confusing.
So let's name it what it is, please. Not what somebody else named it.