Attention is currently required from: Martin L Roth, Martin Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68195 )
Change subject: soc/amd/morgana: Add initial commit for new SoC ......................................................................
Patch Set 4: Verified+1
(13 comments)
File src/soc/amd/morgana/fsp_m_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160052): https://review.coreboot.org/c/coreboot/+/68195/comment/6e4017c5_0b32f7bc PS4, Line 32: for (i = 0; i < num; i++) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160052): https://review.coreboot.org/c/coreboot/+/68195/comment/08561cbe_95e6ac14 PS4, Line 45: for (i = 0; i < num; i++) { braces {} are not necessary for single statement blocks
File src/soc/amd/morgana/psp_verstage/svc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160052): https://review.coreboot.org/c/coreboot/+/68195/comment/f9096dfc_584f9add PS4, Line 12: #define SVC_CALL4(SVC_ID, R0, R1, R2, R3, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160052): https://review.coreboot.org/c/coreboot/+/68195/comment/4489230e_594873fc PS4, Line 25: #define SVC_CALL3(SVC_ID, R0, R1, R2, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160052): https://review.coreboot.org/c/coreboot/+/68195/comment/3eb37bc4_b9a4f920 PS4, Line 36: #define SVC_CALL2(SVC_ID, R0, R1, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160052): https://review.coreboot.org/c/coreboot/+/68195/comment/e6f1fc28_0555deb1 PS4, Line 46: #define SVC_CALL1(SVC_ID, R0, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160052): https://review.coreboot.org/c/coreboot/+/68195/comment/77d65e5f_71253cea PS4, Line 55: #define SVC_CALL0(SVC_ID, Ret) \ Macros with complex values should be enclosed in parentheses
File src/soc/amd/morgana/root_complex.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160052): https://review.coreboot.org/c/coreboot/+/68195/comment/16ba1769_16682339 PS4, Line 87: * | | X86_RESET_VECTOR = BOOTBLOCK_END - 0x10 line length of 98 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160052): https://review.coreboot.org/c/coreboot/+/68195/comment/08483594_a7f2fda8 PS4, Line 90: * +--------------------------------+ BOOTBLOCK_ADDR = BOOTBLOCK_END - C_ENV_BOOTBLOCK_SIZE line length of 111 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160052): https://review.coreboot.org/c/coreboot/+/68195/comment/8282564c_f59b1608 PS4, Line 95: * +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE + PRERAM_CBMEM_CONSOLE_SIZE + 0x200 line length of 133 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160052): https://review.coreboot.org/c/coreboot/+/68195/comment/3c9b34f8_78d21a39 PS4, Line 97: * +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE + PRERAM_CBMEM_CONSOLE_SIZE line length of 125 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160052): https://review.coreboot.org/c/coreboot/+/68195/comment/ff3c67b4_4e3406c5 PS4, Line 100: * +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE line length of 97 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160052): https://review.coreboot.org/c/coreboot/+/68195/comment/fad5ba55_dc6a5b85 PS4, Line 182: reserved_ram_resource_kb(dev, idx++, res->addr / KiB, res->length / KiB); line length of 97 exceeds 96 columns