Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35439 )
Change subject: sb/intel/ibexpeak: Add CIR initialization ......................................................................
Patch Set 6:
(10 comments)
https://review.coreboot.org/c/coreboot/+/35439/1/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/early_cir.c:
https://review.coreboot.org/c/coreboot/+/35439/1/src/southbridge/intel/ibexp... PS1, Line 41: CIR6
According to intel magic: […]
Done, however lpc.c l320 does touch this too :/ It seems to work now.
https://review.coreboot.org/c/coreboot/+/35439/1/src/southbridge/intel/ibexp... PS1, Line 51: PMIR
According to intel magic: […]
Ack
https://review.coreboot.org/c/coreboot/+/35439/1/src/southbridge/intel/ibexp... PS1, Line 58: 0x7f8fdf80
Intel magic suggests 0x7F8F9F80 instead
That's the EDS value. I'll use that.
https://review.coreboot.org/c/coreboot/+/35439/1/src/southbridge/intel/ibexp... PS1, Line 59: /* Does not match EDS */
I don't think anybody tested Lynnfield/Clarksfield hardware. I would use the EDS value. […]
Ack
https://review.coreboot.org/c/coreboot/+/35439/1/src/southbridge/intel/ibexp... PS1, Line 62: 0x6002000
Intel magic suggests 0x2000 instead
Ack
https://review.coreboot.org/c/coreboot/+/35439/1/src/southbridge/intel/ibexp... PS1, Line 70: RCBA32(CIR10) = 0xfffff;
According to intel magic: […]
Ack
https://review.coreboot.org/c/coreboot/+/35439/1/src/southbridge/intel/ibexp... PS1, Line 71: RCBA32(CIR15) = 0x7f8fdfff;
Intel magic suggests 0x7F8F9FFF instead
Ack
https://review.coreboot.org/c/coreboot/+/35439/1/src/southbridge/intel/ibexp... PS1, Line 72: RCBA32(CIR17) = 0x3900;
Intel magic suggests 0x2900 instead, but my system has 0x3900
Ack
https://review.coreboot.org/c/coreboot/+/35439/1/src/southbridge/intel/ibexp... PS1, Line 73: RCBA32(CIR19) = 0x10000;
Intel magic suggests 0x10001 instead, but my system has 0x10000
Ack
https://review.coreboot.org/c/coreboot/+/35439/1/src/southbridge/intel/ibexp... PS1, Line 75: RCBA32(CIR21) = 0x6000008;
Intel magic says this value on my system is correct, but other intel magic suggests 0x0000008
Ack