Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44081 )
Change subject: device/pci_device.c: Drop static device checking code ......................................................................
Patch Set 1: Code-Review-2
(2 comments)
Patch Set 1: Code-Review-2
Not saying it can't be done, but first we have to understand what the removed code did. Please read it. It's more than just printing messages.
Yes, I see we're not doing something that seems to be rather important. I wonder how many fireworks happen with this change as-is.
https://review.coreboot.org/c/coreboot/+/44081/1/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/44081/1/src/device/pci_device.c@a12... PS1, Line 1293: prev = &dev->sibling; This replaces `prev` with the next element (walks down the chain)
https://review.coreboot.org/c/coreboot/+/44081/1/src/device/pci_device.c@a12... PS1, Line 1298: *prev = dev->sibling; This makes `prev` point to the next element, skipping over the current element.