Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35762 )
Change subject: sb/intel/ibexpeak: Implement USB current settings ......................................................................
Patch Set 8: Code-Review+2
(6 comments)
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/early_usb.c:
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp... PS8, Line 29: const u16 currents[] = { 0xf57, 0xf5f, 0x753, 0x75f, : 0x14b, 0x74b, 0x557, 0x757, : 0x55f, 0x54b please use the 96-character line length limit :D
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp... PS8, Line 38: 14 magic?
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp... PS8, Line 51: 14 magic!
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp... PS8, Line 56: 8 more magic!
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp... PS8, Line 66: Double space
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/pch.h:
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp... PS8, Line 72: current_lookup_idx Any clue as to what these mean?