Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36679 )
Change subject: {drivers,mainboard}: Move FSP logo support to fsp1_1 ......................................................................
Patch Set 7:
(4 comments)
Patch Set 4: Code-Review-1
(5 comments)
This function is called nowhere?
The patch was incomplete. Added the missing file and adessed the other items you reported.
https://review.coreboot.org/c/coreboot/+/36679/6/src/drivers/intel/fsp1_1/lo... File src/drivers/intel/fsp1_1/logo.c:
https://review.coreboot.org/c/coreboot/+/36679/6/src/drivers/intel/fsp1_1/lo... PS6, Line 26: CBFS_TYPE_RAW);
please, no space before tabs
Done
https://review.coreboot.org/c/coreboot/+/36679/6/src/drivers/intel/fsp1_1/lo... PS6, Line 26: CBFS_TYPE_RAW);
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/36679/6/src/drivers/intel/fsp1_1/lo... PS6, Line 26: CBFS_TYPE_RAW);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/36679/6/src/drivers/intel/fsp1_1/lo... PS6, Line 29: printk(BIOS_DEBUG, "Found a Logo of %d bytes after decompression\n", params->PcdLogoSize);
line over 96 characters
Done