[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/{tgl,adl}: Hook up D3ColdEnable UPD to D3COLD_SUPPORT

[Michael Niewöhner (Code Review)]

Attention is currently required from: Sean Rhodes.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72800 )

Change subject: soc/intel/{tgl,adl}: Hook up D3ColdEnable UPD to D3COLD_SUPPORT
......................................................................

Patch Set 8:

(1 comment)

File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/72800/comment/fa128993_af52a718 
PS4, Line 325: 	params->D3HotEnable = !config->TcssD3HotDisable;
             : 
             : 	cpu_id = cpu_get_cpuid();
             : 	if (cpu_id == CPUID_TIGERLAKE_A0)
             : 		params->D3ColdEnable = 0;
             : 	else
             : 		params->D3ColdEnable = CONFIG(D3COLD_SUPPORT);
             : 
does this make any sense at all? first setting D3HotEnable to the dt value, then overriding it?