Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36915 )
Change subject: pcengines/apu2: Switch away from ROMCC_BOOTBLOCK
......................................................................
Patch Set 30:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36915/27//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36915/27//COMMIT_MSG@7
PS27, Line 7: mb/pcengines/apu2: move to C bootblock
pcengines/apu2: Switch away from ROMCC_BOOTBLOCK […]
Done
https://review.coreboot.org/c/coreboot/+/36915/28/src/mainboard/pcengines/ap...
File src/mainboard/pcengines/apu2/romstage.c:
https://review.coreboot.org/c/coreboot/+/36915/28/src/mainboard/pcengines/ap...
PS28, Line 41: pm_io_write8(0xea, 1);
pm_write8() now that ACPIMMIO is enabled in bootblock already? […]
No PCI-PCI bridge in BKDG or any other bit description than GenIntDIsable for GPIO32 and 33 in the PMxEA.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36915
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If770eff467b9a71d21eeb0963b6c3ebe72a88ef3
Gerrit-Change-Number: 36915
Gerrit-PatchSet: 30
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 04 Dec 2019 18:17:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment