[coreboot-gerrit] Change in ...coreboot[master]: soc/amd/stoneyridge: Move IOMMU support to common

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32657 )

Change subject: soc/amd/stoneyridge: Move IOMMU support to common
......................................................................

Patch Set 5:

(3 comments)

https://review.coreboot.org/#/c/32657/4/src/soc/amd/common/block/iommu/iommu... 
File src/soc/amd/common/block/iommu/iommu.c:

https://review.coreboot.org/#/c/32657/4/src/soc/amd/common/block/iommu/iommu... 
PS4, Line 46: 0
> DEVICE_NOOP?

IIRC we were removing unimplemented ones instead.

https://review.coreboot.org/#/c/32657/4/src/soc/amd/common/block/iommu/iommu... 
PS4, Line 47: 0
> DEVICE_NOOP?

same

https://review.coreboot.org/#/c/32657/4/src/soc/amd/common/block/iommu/iommu... 
PS4, Line 54: PCI_DEVICE_ID_AMD_15H_MODEL_707F_NB_IOMMU
> This will have to be transformed into a list of pci device_ids.

Done